Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI workflow for breaking changes needs to be updated to match the new label #15859

Open
alice-i-cecile opened this issue Oct 11, 2024 · 0 comments
Open

CI workflow for breaking changes needs to be updated to match the new label #15859

alice-i-cecile opened this issue Oct 11, 2024 · 0 comments
Labels
A-Build-System Related to build systems or continuous integration A-Meta About the project itself D-Trivial Nice and easy! A great choice to get started with Bevy P-High This is particularly urgent, and deserves immediate attention S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@alice-i-cecile
Copy link
Member

bevy/.github/workflows/action-on-PR-labeled.yml

Line 17 in 60a9a81

if: github.event.label.name == 'C-Breaking-Change' && !contains(github.event.pull_request.body, '## Migration Guide')

This needs to use the newly renamed M-Needs-Migration-Guide label. Spotted in bevyengine/bevy-website#1646
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-Build-System Related to build systems or continuous integration P-High This is particularly urgent, and deserves immediate attention A-Meta About the project itself S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration A-Meta About the project itself D-Trivial Nice and easy! A great choice to get started with Bevy P-High This is particularly urgent, and deserves immediate attention S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alice-i-cecile