Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest v3 #215

Merged
merged 10 commits into from
Jun 16, 2024
Merged

Manifest v3 #215

merged 10 commits into from
Jun 16, 2024

Conversation

bhollis
Copy link
Owner

@bhollis bhollis commented Jun 16, 2024

This switches JSONView to the "Manifest V3" APIs. Unfortunately, this is a more restrictive set of APIs, so some features have been removed (namely, access to the JSON data in the console). I also now have to build slightly different packages for Firefox and Chrome-based browsers, as they differ in what they support.

I also fixed a couple other issues while I was in there.

import tseslint from "typescript-eslint";

export default tseslint.config(
{ name: "eslint/recommended", ...eslint.configs.recommended },

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected ')' and instead saw 'eslint'.
Expected '}' to match '{' from line 10 and instead saw '...'.
Missing semicolon.
Unrecoverable syntax error. (4% scanned).

import globals from "globals";
import tseslint from "typescript-eslint";

export default tseslint.config(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'export' is only available in ES6 (use 'esversion: 6').

import github from "eslint-plugin-github";
import sonarjs from "eslint-plugin-sonarjs";
import globals from "globals";
import tseslint from "typescript-eslint";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').

import arrayFunc from "eslint-plugin-array-func";
import github from "eslint-plugin-github";
import sonarjs from "eslint-plugin-sonarjs";
import globals from "globals";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').

import eslint from "@eslint/js";
import arrayFunc from "eslint-plugin-array-func";
import github from "eslint-plugin-github";
import sonarjs from "eslint-plugin-sonarjs";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').

import { fixupPluginRules } from "@eslint/compat";
import eslint from "@eslint/js";
import arrayFunc from "eslint-plugin-array-func";
import github from "eslint-plugin-github";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').

@@ -0,0 +1,209 @@
import { fixupPluginRules } from "@eslint/compat";
import eslint from "@eslint/js";
import arrayFunc from "eslint-plugin-array-func";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').

@@ -0,0 +1,209 @@
import { fixupPluginRules } from "@eslint/compat";
import eslint from "@eslint/js";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').

@@ -0,0 +1,209 @@
import { fixupPluginRules } from "@eslint/compat";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').

@bhollis bhollis merged commit bf7a463 into master Jun 16, 2024
2 checks passed
@bhollis bhollis deleted the manifest-v3 branch June 16, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants