Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for .nwb standard/file format to be used for "micr" #1632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yarikoptic
Copy link
Collaborator

See https://pynwb.readthedocs.io/en/stable/tutorials/domain/ophys.html for support of various microscopy modalities within NWB. As NWB is already supported for other modalities, there is some support for microscopy in NWB in various tools, and as there are datasets with .nwb -- it makes sense to allow for .nwb to be used for microscopy data as well where appropriate.

@satra
Copy link
Collaborator

satra commented Oct 18, 2023

this may be more of a question of physiology versus microscopy. in bids micr is focused on anatomy-based info not physiology. and i don't think nwb quite fits into that space. ophys doesn't fit into micr as far as i can tell. in bids ophys would go into func.

@satra
Copy link
Collaborator

satra commented Oct 18, 2023

or phys if that was to become a new modality.

@yarikoptic
Copy link
Collaborator Author

yarikoptic commented Oct 18, 2023

re "functional vs anatomical"

related discussions to tease apart those two notions of modality (MRI, micr, ...) and data type (anat vs func):

Note that nothing in https://bids-specificabtrcitetcjtion.readthedocs.io/en/stable/04-modality-specific-files/10-microscopy.html explicitly restricts to anatomy (in effect - allows for extra), although indeed lacks any annotation for temporal component and events (requires "extending").
Overall the fact that we have anat/ and func/ ATM is an artifact of early days orientation toward MRI, and peculiarity that some modalities are purely functional (e.g. EEG, MEG) thus not even raising the question. But then if we look at PET -- we can have a single volume PET, or "functional PET" for which _events.tsv is then required.

So I could argue about similarity to this case here

re phys vs micr

ATM microscopy is for the modality, and it already supports 2PE which I guess also falls into "phys" domain.
As all other "modality/" folders are really instrumentation modality, I would argue that we better not place microscopy data under electrophysiology folder.

@sappelhoff
Copy link
Member

has there been a request by a user / a particular group of users to make this happen?

If not, I would wait with introducing such a change, and remain "use case driven".

Especially when an argument of being "consistent" isn't entirely clear (as I get the impression, reading the discussion above)

@yarikoptic
Copy link
Collaborator Author

has there been a request by a user / a particular group of users to make this happen?

it was brought up as a side-topic in discussion of BEP032 (@BEP032) .

remain "use case driven".

LGTM. @bendichter, are you aware of any DANDI set with nwb microscopy data which we would run to while approaching conversion of DANDI dandisets to BIDS?

@sappelhoff sappelhoff marked this pull request as draft November 30, 2023 14:13
See https://pynwb.readthedocs.io/en/stable/tutorials/domain/ophys.html for support
of various microscopy modalities within NWB.  As NWB is already supported for
other modalities, there is some support for microscopy in NWB in various tools,
and as there are datasets with .nwb -- it makes sense to allow for .nwb to be used
for microscopy data as well where appropriate.
@yarikoptic
Copy link
Collaborator Author

There is an ongoing effort of https://github.com/con/nwb2bids . Not yet sure how we would deal with multimodal nwb files like in https://dandiarchive.org/dandiset/000037/0.240209.1623/files?location=sub-408021&page=1 but I remain of opinion that NWB is a viable and used format for micr... I will rebase and take it out of the draft.

@yarikoptic yarikoptic marked this pull request as ready for review April 13, 2024 15:20
Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.93%. Comparing base (943c20e) to head (97bd21c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1632   +/-   ##
=======================================
  Coverage   87.93%   87.93%           
=======================================
  Files          16       16           
  Lines        1351     1351           
=======================================
  Hits         1188     1188           
  Misses        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Collaborator

What benefits does micr/*.nwb have over micr/*.ome.zarr? There is a cost to tool writers to proliferating formats within a modality, hence why we do not support MINC.

That said, I know nothing of this space, and IMO this needs input from microscopy contributors. @jcohenadad do you have thoughts here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants