Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Move description of "n/a" above "String values" to avoid any association #1940

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FIX] Move description of "n/a" above "String values" to avoid any association #1940

wants to merge 1 commit into from

Conversation

yarikoptic
Copy link
Collaborator

@yarikoptic yarikoptic commented Oct 3, 2024 •
edited
Loading

as they should be applicable also to numeric values.

@yarikoptic yarikoptic mentioned this pull request Oct 4, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.87%. Comparing base (7ddb7be) to head (2fc9888).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1940   +/-   ##
=======================================
  Coverage   86.87%   86.87%           
=======================================
  Files          16       16           
  Lines        1410     1410           
=======================================
  Hits         1225     1225           
  Misses        185      185

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Collaborator Author

@bids-maintenance - this is an easy low hanging fruit PR.

@yarikoptic yarikoptic added schema Issues related to the YAML schema representation of the specification. Patch version release. and removed schema Issues related to the YAML schema representation of the specification. Patch version release. labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

@DimitriPapadopoulos DimitriPapadopoulos Awaiting requested review from DimitriPapadopoulos DimitriPapadopoulos is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] clarify/re-consider use of "n/a" in numeric columns
2 participants
@yarikoptic @effigies