-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Markdown for Bep032 #1960
Draft
Peyman-N
wants to merge
15
commits into
bids-standard:bep032
Choose a base branch
from
Peyman-N:bep032-peyman
base: bep032
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
effigies
added
the
exclude-from-changelog
This item will not feature in the automatically generated changelog
label
Oct 16, 2024
for more information, see https://pre-commit.ci
yarikoptic
requested changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I left only some styling/formatting recommendations for now.
src/modality-specific-files/microelectrode-electrophysiology.md
Outdated
Show resolved
Hide resolved
src/modality-specific-files/microelectrode-electrophysiology.md
Outdated
Show resolved
Hide resolved
src/modality-specific-files/microelectrode-electrophysiology.md
Outdated
Show resolved
Hide resolved
src/modality-specific-files/microelectrode-electrophysiology.md
Outdated
Show resolved
Hide resolved
src/modality-specific-files/microelectrode-electrophysiology.md
Outdated
Show resolved
Hide resolved
Example of * _probes.tsv: | ||
|
||
|
||
|probe_id|hemisphere|x|y|z|type|material|location| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check other examples in the spec. E.g.
Example of the content of the TSV file: |
they should not be formatted into a table
src/modality-specific-files/microelectrode-electrophysiology.md
Outdated
Show resolved
Hide resolved
src/modality-specific-files/microelectrode-electrophysiology.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Yaroslav Halchenko <[email protected]>
Co-authored-by: Yaroslav Halchenko <[email protected]>
Co-authored-by: Yaroslav Halchenko <[email protected]>
Co-authored-by: Yaroslav Halchenko <[email protected]>
Co-authored-by: Yaroslav Halchenko <[email protected]>
Co-authored-by: Yaroslav Halchenko <[email protected]>
Co-authored-by: Yaroslav Halchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--- PLEASE READ AND DELETE THE TEXT BELOW BEFORE OPENING THE PULL REQUEST ---
See the CONTRIBUTING guide. Specifically:
Please keep the title of your Pull Request (PR) short but informative - it will appear in the changelog.
If you do not want a PR to appear in the changelog, it must receive the
exclude-from-changelog
label.Please ensure your name is credited
on our Contributors appendix.
To add your name, please edit our Contributors wiki
and add your name with the type of contribution.
For assistance, please tag @bids-standard/maintainers.
Use one of the following prefixes in the title of your PR:
[ENH]
- enhancement of the specification that adds a new feature or support for a new data type[FIX]
- fix of a typo or language clarification[INFRA]
- changes to the infrastructure automating the specification release (for example building HTML docs)[SCHEMA]
- changes to the BIDS schema and/or related code[MISC]
- everything else including changes to the file listing contributorsIf you are opening a PR to obtain early feedback,
but the changes are not ready to be merged (also known as a "Work in Progress" PR),
please use a Draft PR.
After opening the PR, our continuous integration services will automatically check your contribution
for formatting errors and render a preview of the BIDS specification with your changes.
To see the checks and preview, scroll down and click on the
show all checks
link.From the list:
Details
link of thedocs/readthedocs.org:bids-specification
check to see the HTML preview of the BIDS specification.Details
link of theCheck the rendered PDF version here!
check to see the PDF preview of the BIDS specification.If you are updating the schema and you need to subsequently make changes to the bidsschematools code (validation, tests, rendering),
this means your PR probably introduces a compatibility breaking change
and you should increment the minor version (the second number) in
bids-specification/src/schema/SCHEMA_VERSION
.If you are opening a PR for a BIDS extension proposal (BEP),
make sure that your top message contains the following notes
Note
We meet regularly to discuss this BEP
Next meeting: insert date on URL to join
Communication channel on github repo / matrix / slack / discord : insert URL to join
Tip
[HTML preview of this BEP](insert URL to HTML preview once available)
--- PLEASE READ AND DELETE THE TEXT ABOVE BEFORE OPENING THE PULL REQUEST ---