Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'dataset_config_name' field to config.py with metadata #88

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

giprime
Copy link

@giprime giprime commented Jun 28, 2023

#32 #59
I had same error right after training finished. So I investigated about this.
Searching by keyword, I found code examples that I think the author may have referenced in writing the initial code from huggingface transformers examples.
https://github.com/huggingface/transformers/blob/main/examples/pytorch/language-modeling/run_plm.py

The authors of transformer appear to be using this value to specify subset of dataset.
E.g., specifying sst2 which is a subset of the glue dataset (https://huggingface.co/docs/datasets/v1.11.0/loading_datasets.html#selecting-a-configuration)
This value later functions as the name parameter of datasets.load_dataset.
(https://huggingface.co/docs/datasets/v1.11.0/package_reference/loading_methods.html#datasets.load_dataset)

This setting was excluded from writing train.py in starcoder, but the logic to check which dataset and subset was used at the time of saving the model was not excluded.
So it appears that the issue is caused by trying to reference a setting that doesn't exist.

A solution might be to remove the logic that checks the subset name.
However, since I guess that this code may also use a dataset with a subset, I think the setting value should be added to config.py and config field should be made to set the value in train.py. It is an optional parameter that will be None if not set by the user.

How about add 'dataset_config_name' field to config.py with metadata of transformer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant