Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mantra GSC new location (closes #891) #916

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

phlobo
Copy link
Collaborator

@phlobo phlobo commented Mar 20, 2024

Closes #891

Mantra GSC was moved from the original website to GitHub:
https://github.com/mi-erasmusmc/Mantra-Gold-Standard-Corpus/tree/main

This PR makes the loader point to the new URL and creates a HF Hub version of the existing loader script for mantra_gsc.

If the following information is NOT present in the issue, please populate:

Checkbox

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script hub/hub_repos/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
  • Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _BIGBIO_VERSION variables.
  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one BigBioConfig for the source schema and one for a bigbio schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_bigbio_hub <dataset_name> [--data_dir /path/to/local/data] --test_local.
  • If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

Copy link
Collaborator

@leonweber leonweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for your contribution! 🎉

@leonweber leonweber merged commit 105cab1 into bigscience-workshop:main Jun 4, 2024
@leonweber
Copy link
Collaborator

@phlobo I cannot push mantra_gsc to the hub because of the following error:

- "language[0]" with value "en, fr, de, nl, es" is not valid. It must be an ISO 639-1, 639-2 or 639-3 code (two/three letters), or a special value like "code", "multilingual". If you want to use BCP-47 identifiers, you can specify them in language_bcp47.

Could you please open a PR to fix this?

@phlobo
Copy link
Collaborator Author

phlobo commented Jun 7, 2024

@leonweber thank you for taking care of this, please see #923

phlobo added a commit to davidkartchner/biomedical that referenced this pull request Oct 21, 2024
…workshop#916)

* SympTEMIST dataloader

* Readme

* Mantra GSC New Location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mantra GSC not on Hf Hub?
2 participants