Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lrzip build for osx-arm64 #49158

Closed
wants to merge 4 commits into from
Closed

lrzip build for osx-arm64 #49158

wants to merge 4 commits into from

Conversation

lcoombe
Copy link
Contributor

@lcoombe lcoombe commented Jul 11, 2024


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@lcoombe
Copy link
Contributor Author

lcoombe commented Jul 11, 2024

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Jul 11, 2024
@@ -10,7 +10,7 @@ source:
sha256: 48bd8decb097c1596c9b3777959cd3e332819434ed77a2823e65aa436f1602f9

build:
number: 0
number: 1
skip: True # [osx]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
skip: True # [osx]
skip: True # [osx and x86_64]

Right now it's skipping all osx. If you want to exclude osx-64 but build osx-arm64, you can make this change. Or if you want both, just remove this skip line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks for noticing that @aliciaaevans! I was bumping this because I need osx-arm64 lrzip for some of our other tools to build on osx-arm64. Not sure why it was set to skip osx before - will try removing that!

@lcoombe
Copy link
Contributor Author

lcoombe commented Jul 11, 2024

Looks like newer lrzip versions don't work on macOS (ex. ckolivas/lrzip#193) - I didn't realize I was opening a can of worms!
I'll close this and will consider removing the lrzip dependency for btllib upstream if we want an osx-arm64 build.

@lcoombe lcoombe closed this Jul 11, 2024
@martin-g
Copy link
Contributor

@lcoombe You may try to replace it with lrzip-next. According to pete4abw/lrzip-next#98 (comment) it should work better for OSX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants