Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create FC-Virus #51579

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+31 −0
Open

Create FC-Virus #51579

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48e2e8b
Create FC-Virus
qdu-bioinfo Oct 23, 2024
3405d09
Update FC-Virus
qdu-bioinfo Oct 23, 2024
a1b6e48
Merge branch 'master' into patch-5
qdu-bioinfo Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions recipes/FC-Virus/mete.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
package:
name: FC-Virus
version: "1.0.0"
noarch: generic

source:
url: https://github.com/qdu-bioinfo/FC-Virus/archive/refs/heads/main.tar.gz
git_tag: main
sha256: a5c91ea315dc7b64b75986128d97c08522aae332cb640fd2c115cc379b4adc51
Comment on lines +6 to +9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Use a specific release tag instead of main branch

Using the main branch as the source is not recommended for reproducibility as it can change over time. Since this is version 1.0.0, you should:

  1. Create a release tag (v1.0.0) in the FC-Virus repository
  2. Update the URL to point to the release tag
  3. Update git_tag to match the release tag

Apply this diff:

 source:
-  url: https://github.com/qdu-bioinfo/FC-Virus/archive/refs/heads/main.tar.gz
-  git_tag: main
+  url: https://github.com/qdu-bioinfo/FC-Virus/archive/refs/tags/v1.0.0.tar.gz
+  git_tag: v1.0.0
   sha256: a5c91ea315dc7b64b75986128d97c08522aae332cb640fd2c115cc379b4adc51
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
source:
url: https://github.com/qdu-bioinfo/FC-Virus/archive/refs/heads/main.tar.gz
git_tag: main
sha256: a5c91ea315dc7b64b75986128d97c08522aae332cb640fd2c115cc379b4adc51
source:
url: https://github.com/qdu-bioinfo/FC-Virus/archive/refs/tags/v1.0.0.tar.gz
git_tag: v1.0.0
sha256: a5c91ea315dc7b64b75986128d97c08522aae332cb640fd2c115cc379b4adc51


build:
number: 0
skip: true

Comment on lines +11 to +14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove skip: true and revise package architecture

Two issues with the build configuration:

  1. skip: true will prevent the package from being built at all
  2. noarch: generic is incompatible with platform-specific dependencies like gcc and gxx_linux-64

Apply these changes:

-  noarch: generic
 build:
   number: 0
-  skip: true

Committable suggestion was skipped due to low confidence.

requirements:
build:
- gcc
- gxx_linux-64
- make
- boost
run:
- boost
Comment on lines +15 to +22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Reorganize dependencies following conda-forge best practices

The dependencies section needs several improvements:

  1. Use conda-forge's compiler syntax
  2. Add version constraints
  3. Organize dependencies into build, host, and run sections

Apply this diff:

 requirements:
   build:
-    - gcc
-    - gxx_linux-64
     - make
+    - {{ compiler('c') }}
+    - {{ compiler('cxx') }}
+  host:
     - boost >=1.70.0
   run:
-    - boost
+    - boost >=1.70.0
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
requirements:
build:
- gcc
- gxx_linux-64
- make
- boost
run:
- boost
requirements:
build:
- make
- {{ compiler('c') }}
- {{ compiler('cxx') }}
host:
- boost >=1.70.0
run:
- boost >=1.70.0


about:
home: https://github.com/qdu-bioinfo/FC-Virus
license: MIT
summary: "Accurate Assembly of Full-length Consensus for Viral Quasispecies"

test:
commands:
- ./bin/FC-Virus --help