Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: windows download error #381

Merged
merged 3 commits into from
Oct 6, 2024
Merged

fix: windows download error #381

merged 3 commits into from
Oct 6, 2024

Conversation

ahaoboy
Copy link
Contributor

@ahaoboy ahaoboy commented Oct 6, 2024

Summary

platformSpecificPackageName:

biome-win32-arm64
biome-win32-x64

biome name

biome-win32-arm64.exe
biome-win32-x64.exe

Checklist

  • I have tested my changes on the following platforms:
  • Windows
  • Linux
  • macOS

@ahaoboy ahaoboy requested review from nhedger and a team as code owners October 6, 2024 04:05
@nhedger
Copy link
Member

nhedger commented Oct 6, 2024

Hey, thanks for catching this and opening a PR. I think I prefer to use a constant instead. I'll push changes to your branch.

@ahaoboy
Copy link
Contributor Author

ahaoboy commented Oct 6, 2024

Hey, thanks for catching this and opening a PR. I think I prefer to use a constant instead. I'll push changes to your branch.

Haha, yes, this value will probably be used a lot, but I'm too lazy to come up with a name :D

@nhedger nhedger merged commit fd39634 into biomejs:main Oct 6, 2024
2 checks passed
@nhedger
Copy link
Member

nhedger commented Oct 6, 2024

Thanks @ahaoboy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

@nhedger nhedger Awaiting requested review from nhedger nhedger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahaoboy @nhedger @ematipico