fix(lsp): don't apply unsafe quick fixes on-save #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conaclos
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
github-actions
bot
added
A-Project
Conaclos
force-pushed
the
conaclos/lsp-no-unsafe-quickfixes-on-save
branch
from
1f47f73
to
934a52b
Compare
Conaclos
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
ematipico
reviewed
Aug 24, 2023
ematipico
changed the title
Conaclos
force-pushed
the
conaclos/lsp-no-unsafe-quickfixes-on-save
branch
from
934a52b
to
189b1c9
Compare
Conaclos
temporarily deployed
to
Website deployment
GitHub Actions
Inactive
I added two tests. I found the LSP code a bit complex. I wonder if there is room for simplification... It's certainly not ideal that extracting quickfixes only results in the extraction of safe quickfixes. Quickfixes on tooltips are part of an unfiltered query. |
ematipico
approved these changes
Aug 25, 2023
|
This PR should also fix rome#4748. By the way, this brings a question: what is the difference between |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR avoids applying unsafe fixes when quickfixes are triggered on-save.
Unsafe quickfixes are still available in the IDE via direct invocation.
Test Plan
Manually tested.