-
-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lsp): don't apply unsafe quick fixes on-save #62
Conversation
1f47f73
to
934a52b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance we can create a test?
934a52b
to
189b1c9
Compare
I added two tests. I found the LSP code a bit complex. I wonder if there is room for simplification... It's certainly not ideal that extracting quickfixes only results in the extraction of safe quickfixes. Quickfixes on tooltips are part of an unfiltered query. |
This PR should also fix rome#4748. By the way, this brings a question: what is the difference between |
Summary
This PR avoids applying unsafe fixes when quickfixes are triggered on-save.
Unsafe quickfixes are still available in the IDE via direct invocation.
Test Plan
Manually tested.