FEAT: add code navigation to script editor #1660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds code navigation by registering a CodeEditorOpener to monaco.
d0sboots
reviewed
Oct 8, 2024
| return true; | ||
| } | ||
|
|
||
| if ((selectionOrPosition as monaco.IRange) !== undefined) { |
There was a problem hiding this comment.
as is a compile-time-only thing, it doesn't do anything at runtime. You'll need to do something like startLineNumber in selectionOrPosition
There was a problem hiding this comment.
Good to know, thanks for the hint.
| rerender(); | ||
| removeOutlineOfEditor(); | ||
| }); | ||
| vim = props.vim; |
There was a problem hiding this comment.
When using code navigation, monaco might open a file that has not been loaded yet. Originally, props.vim is set by the parent ReactNode when calling OnMount; unfortunately, the CodeEditorOpener doesn't know the props and hence I save the most recent value so that new files are opened with the latest props.vim setting instead of falling back to a fixed true or false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds code navigation by registering a CodeEditorOpener to monaco.