BLADEBURNER: Refactor BB console commands out of Bladeburner.ts #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No NS api changes. Impacted functionality is fully test-covered.
|
I was hoping the tests would expedite this change. Seems I was wrong, will re-do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No NS api changes. Impacted functionality is fully test-covered.
Motivation
This is the biggest move out of Bladeburner.ts so far.
We're almost sub-1k lines from originally 1500, a solid 25% decrease.
Cohesion has increased considerably with this change as the console commands can all run through a single public API and do not require all the implementation details or help in the main Bladeburner file.
Review suggestions
The added files in Console/Commands are kept original verbatim except for translating this. to blade.
Github diff doesn't show that very well.