Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLADEBURNER: UI now shows tooltips on action success chance to show stat scaling #1699

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

Alpheus
Copy link
Contributor

@Alpheus Alpheus commented Oct 18, 2024

BLADEBURNER: UI now shows tooltips on action success chance to show stat scaling

Hovering over the "estimated success chance" text now shows what stats it scales from. Plus description for Black Ops to keep them focused on the lore text.

Motivation

Joining bladeburner requires 100 combat stats but it's never explained how or why it is relevant to gameplay. Hoping this tooltip will help connect the dots.

Looking for review/feedback on:

  • wording, spacing
  • tooltip alternatives
  • tooltip shape
  • (optional) whether to generate the tooltips from weights

@d0sboots
Copy link
Collaborator

Can you add a screenshot of the tooltip in action? Also, what happens when there's no text? It looks like it'll make an empty tooltip, probably better to not have a tooltip in that case.

Aside from that, looks good.

@Alpheus
Copy link
Contributor Author

Alpheus commented Oct 20, 2024

Can you add a screenshot of the tooltip in action? Also, what happens when there's no text? It looks like it'll make an empty tooltip, probably better to not have a tooltip in that case.

Aside from that, looks good.

I checked the docs for nullish titles and this is what they claim:

-- | -- | -- | --
Tooltip title. Zero-length titles string, undefined, null and false are never displayed.
-- | -- | -- | --

from: https://mui.com/material-ui/api/tooltip/

Is the wrapped empty component an issue? I can cycle it out with a ternary but it becomes much harder to read (relative to the existing simplicity)

Screenshot:
image

@d0sboots d0sboots merged commit 2e6aa89 into bitburner-official:dev Oct 21, 2024
6 checks passed
@d0sboots
Copy link
Collaborator

Is the wrapped empty component an issue? I can cycle it out with a ternary but it becomes much harder to read (relative to the existing simplicity)

Nope, that's fine then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants