Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Change type of skill name parameter of skillMaxUpgradeCount API #1712

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,18 @@ Calculate the number of times that you can upgrade a skill.
**Signature:**

```typescript
skillMaxUpgradeCount(name: string, level: number, skillPoints: number): number;
skillMaxUpgradeCount(
name: BladeburnerSkillName | `${BladeburnerSkillName}`,
level: number,
skillPoints: number,
): number;
```

## Parameters

| Parameter | Type | Description |
| --- | --- | --- |
| name | string | Skill name. It's case-sensitive and must be an exact match. |
| name | [BladeburnerSkillName](./bitburner.bladeburnerskillname.md) \| \`${[BladeburnerSkillName](./bitburner.bladeburnerskillname.md)<!-- -->}\` | Skill name. It's case-sensitive and must be an exact match. |
| level | number | Skill level. It must be a non-negative number. |
| skillPoints | number | Number of skill points to upgrade the skill. It must be a positive number. |

Expand Down
6 changes: 5 additions & 1 deletion src/ScriptEditor/NetscriptDefinitions.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5332,7 +5332,11 @@ interface BladeburnerFormulas {
* @param skillPoints - Number of skill points to upgrade the skill. It must be a positive number.
* @returns Number of times that you can upgrade the skill.
*/
skillMaxUpgradeCount(name: string, level: number, skillPoints: number): number;
skillMaxUpgradeCount(
name: BladeburnerSkillName | `${BladeburnerSkillName}`,
level: number,
skillPoints: number,
): number;
}

/**
Expand Down