Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Tangem Wallet #4233

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sidorovpavel
Copy link

Add Tangem Wallet to wallet list

@crwatkins
Copy link
Contributor

Thanks for your submission. Could you update the "source" entry to point to a specific repository that contains the hardware source instead of pointing to an entire organizaiton?

Have you carefully verified that Tangem Wallet meets all the listing criteria specified here? Do you have any questions on any of the criteria?

@crwatkins
Copy link
Contributor

@sidorovpavel It has been reported that Tangem Wallet

  • Reuses the same address for each Bitcoin transaction in the default mobile app
  • Does not support any apps other than the default mobile app

Is this currently accurate?

@sidorovpavel
Copy link
Author

We reuse the same address for each bitcoin transaction for simplicity.
Yes we does not support any other apps.

@crwatkins
Copy link
Contributor

crwatkins commented Jun 14, 2024

The listing criteria include

  • Avoid address reuse by displaying a new receiving address for each transaction in the wallet UI
  • Avoid address reuse by using a new change address for each transaction

While technically, hardware wallets don't control the selection of receiving addresses (the companion app does) and historically these criteria have not been applied to hardware wallets (since hardware wallets are reviewed independent of the companion app), all of the hardware wallets that are currently listed support multiple companion apps which do not reuse addresses. Since Tangem only has one companion app which reuses addresses, recommending Tangem hardware would be much the same as recommending address reuse.

You may want to review Bitcoin wiki address reuse. Tangem address reuse not only damages the security and the privacy of its users, but it also damages the privacy of the entire community. It is very concerning that any wallet would be doing this in 2024 as there have been no wallets listed that reuse address for about ten years. Respected Bitcoin developers have been more blunt on this subject.

For these reasons, I cannot personally recommend listing of Tangem wallet and I personally will not be doing a full review. Any other members of the community are of course always welcome to provide a review and a recommendation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants