Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI, update py03 to latest version #101

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented May 29, 2024

@notmandatory notmandatory marked this pull request as draft May 29, 2024 01:43
@notmandatory notmandatory force-pushed the deps/upgrade-rust-bitcoin-to-0.32.0 branch 2 times, most recently from e53ad13 to b904922 Compare May 29, 2024 02:29
@ValuedMammal
Copy link

hm, I see speculos had a Traceback with IndexError: bytearray index out of range and I found what looks like a similar issue here LedgerHQ/speculos#488 (comment)

@ValuedMammal
Copy link

I tried with a different firmware version in #102 with no luck. We could possibly try a different device than the nano s.

@notmandatory notmandatory force-pushed the deps/upgrade-rust-bitcoin-to-0.32.0 branch 17 times, most recently from 7e74055 to 474310e Compare June 3, 2024 05:40
@notmandatory
Copy link
Member Author

I got this to build with ubuntu 20.04 and rust 1.63 but with stable rust fails due to an error about requiring glibc 2.33. I think the stable rust version does work with ubuntu 22.04. I suspect some dependency is updated with stable rust and we need to pin that. Interestingly nightly rust works fine with 20.04 (in the doc example test). I think when I tried with ubuntu 22.04 rust 1.63 and nightly failed.

@oleonardolima
Copy link
Contributor

oleonardolima commented Jun 3, 2024

I got this to build with ubuntu 20.04 and rust 1.63 but with stable rust fails due to an error about requiring glibc 2.33. I think the stable rust version does work with ubuntu 22.04. I suspect some dependency is updated with stable rust and we need to pin that. Interestingly nightly rust works fine with 20.04 (in the doc example test). I think when I tried with ubuntu 22.04 rust 1.63 and nightly failed.

@notmandatory I was researching this and the failure started to happen on version 0.8.4 further, the IndexError: bytearray index out of range error seems consistent on all versions from 0.8.4 up to 0.9.1.

In the PR #103 I was playing with the versions, it was only failing due to the glibc error on 1.78 (stable), but it works on previous ones, and in the nightly as you've mentioned (1.80).

It's weird, because I've tried to reproduce the failure on stable locally and wasn't able to, and now it worked on the CI 😅

Maybe it's related to the runner machine being used at the moment CI is running ?

@notmandatory notmandatory force-pushed the deps/upgrade-rust-bitcoin-to-0.32.0 branch 4 times, most recently from c840e54 to b587c10 Compare June 3, 2024 22:24
@notmandatory notmandatory force-pushed the deps/upgrade-rust-bitcoin-to-0.32.0 branch from b587c10 to a714626 Compare June 3, 2024 22:27
@notmandatory notmandatory changed the title testing with no changes Fix CI, update py03 to latest version Jun 3, 2024
@notmandatory notmandatory marked this pull request as ready for review June 3, 2024 22:41
@notmandatory notmandatory self-assigned this Jun 3, 2024
@notmandatory notmandatory added the CI Github Actions label Jun 3, 2024
@notmandatory
Copy link
Member Author

Got it all working! updated description with details.

Copy link

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a714626

.github/workflows/main.yml Show resolved Hide resolved
ci/Dockerfile.ledger Outdated Show resolved Hide resolved
@notmandatory notmandatory force-pushed the deps/upgrade-rust-bitcoin-to-0.32.0 branch from a714626 to d70bd9a Compare June 4, 2024 00:16
@notmandatory notmandatory marked this pull request as draft June 4, 2024 00:23
@notmandatory notmandatory marked this pull request as draft June 4, 2024 00:23
@notmandatory notmandatory marked this pull request as draft June 4, 2024 00:23
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d70bd9a

@notmandatory notmandatory marked this pull request as ready for review June 4, 2024 01:36
@notmandatory notmandatory merged commit 308bde4 into bitcoindevkit:master Jun 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants