Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing wrong precision over accumulated collateral fees amount #3664

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fixing wrong precision over accumulated collateral fees amount #3664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/Account/FeePoolOperation.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class FeePoolOperation extends React.Component {
claimCollateralFeesAmount: 0,
claimCollateralFeesAmountAsset: new Asset({
amount: 0,
precision: this.props.asset.get("precision"),
precision: this.props.core.get("precision"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong. In fact, the asset type of the collateral fee is just the backing asset (see code below), it could be another asset, but not only core.

asset_id: this.props.asset.get("id")
}),
backingAsset: new Asset({
Expand Down