Update TransactionBuilder.js #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@svk31 Hey, do you agree on the solution to this bug? Thanks |
|
Hi there @grctest , did you check in the bitshares-ui how this part is used for proposals? Does the ui only send the number without 1.3.? Proposals have been working from there in the past |
|
I had a look at the end-of-life reference bitshares-ui client, it's not clear where the 1.3 is being removed, however a bug in the bitshares-ui client shouldn't be imposed on the bitsharesjs library. I'd recommend that their package.json remain using v6.0.3 moving forwards, that way it won't break. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue: #137
When creating a proposal, we were incorrectly formatting nested proposal fee asset id's as "1.3.1.3.0" for example, now it's just the fee asset id which fixes the encountered issue.