Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Five refactorings #45

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Five refactorings #45

wants to merge 26 commits into from

Commits on Mar 16, 2019

  1. Dead stores should be removed

    @robinroos
    robinroos committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    d70a029 View commit details
    Browse the repository at this point in the history

  2. Optimize Imports

    @robinroos
    robinroos committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    285216d View commit details
    Browse the repository at this point in the history

  3. Unused "private" fields should be removed

    @robinroos
    robinroos committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    ee5fe85 View commit details
    Browse the repository at this point in the history

  4. Static fields should not be updated in constructors (in this case the… 

    … fields should not be static)
    @robinroos
    robinroos committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    823025c View commit details
    Browse the repository at this point in the history

  5. "throws" declarations should not be superfluous

    @robinroos
    robinroos committed Mar 16, 2019
    Configuration menu
    Copy the full SHA
    d9e7644 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2019

  1. Standard outputs should not be used directly to log anything - in thi… 

    …s case suppress the warning since logging "to stdout" is the express purpose of the class SystemPrintLogger.
    @robinroos
    robinroos committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    8ffd12e View commit details
    Browse the repository at this point in the history

  2. Standard outputs should not be used directly to log anything - in thi… 

    …s case suppress the warning since logging "to stdout" is the express purpose of the class SystemPrintLogger.
    @robinroos
    robinroos committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    863f850 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2019

  1. Merge branch 'master' of https://github.com/bitsofinfo/hazelcast-dock… 

    …er-swarm-discovery-spi into codeformat
    @robinroos
    robinroos committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    c6f761d View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2019

  1. Unused method parameters should be removed 

    Unused constructors should be removed
    @robinroos
    robinroos committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    3ba86ed View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2019

  1. Local variables should be appropriately scoped

    @robinroos
    robinroos committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    d7ffd5c View commit details
    Browse the repository at this point in the history

  2. Remove @SuppressWarnings("squid:S106")

    @robinroos
    robinroos committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    ada0f15 View commit details
    Browse the repository at this point in the history

  3. Reformat code and Optimize Imports

    @robinroos
    robinroos committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    f416d17 View commit details
    Browse the repository at this point in the history

  4. Reformat code and Optimize Imports

    @robinroos
    robinroos committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    7ef9d16 View commit details
    Browse the repository at this point in the history

  5. Variable scope

    @robinroos
    robinroos committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    5ec093b View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2019

  1. Revert to last good build 

    This reverts commit 5ec093b.
    @robinroos
    robinroos committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    f9a5615 View commit details
    Browse the repository at this point in the history

  2. Revert "Reformat code and Optimize Imports" 

    This reverts commit 7ef9d16.
    @robinroos
    robinroos committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    7658ea6 View commit details
    Browse the repository at this point in the history

  3. Revert "Reformat code and Optimize Imports" 

    This reverts commit f416d17.
    @robinroos
    robinroos committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    3b52a61 View commit details
    Browse the repository at this point in the history

  4. Revert "Remove @SuppressWarnings("squid:S106")" 

    This reverts commit ada0f15.
    @robinroos
    robinroos committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    8322458 View commit details
    Browse the repository at this point in the history

  5. Revert "Local variables should be appropriately scoped" 

    This reverts commit d7ffd5c.
    @robinroos
    robinroos committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    c020dbe View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2019

  1. Remove TODO marker

    @robinroos
    robinroos committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    a0453b9 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2019

  1. Reformat code and Optimize Imports

    @robinroos
    robinroos committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    bf5ecab View commit details
    Browse the repository at this point in the history

  2. Remove some whitespace

    @robinroos
    robinroos committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    225027d View commit details
    Browse the repository at this point in the history

  3. Private method overloadings which merely alter argument sequence shou… 

    …ld be removed
    @robinroos
    robinroos committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    eede6f8 View commit details
    Browse the repository at this point in the history

  4. Fields set only in constructors should be final

    @robinroos
    robinroos committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    ec5e0e1 View commit details
    Browse the repository at this point in the history

  5. Fields set only in constructors should be final 

    Factor out processing of comma-delimited strings of tokens and properties
    @robinroos
    robinroos committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    5853324 View commit details
    Browse the repository at this point in the history

  6. Reformat code and Optimize Imports

    @robinroos
    robinroos committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    7a799a6 View commit details
    Browse the repository at this point in the history