Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-9723] Refresh: LoginViaAuthRequestComponent #11545

Open
wants to merge 44 commits into
base: main
Choose a base branch
from

Conversation

rr-bw
Copy link
Contributor

@rr-bw rr-bw commented Oct 14, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9723

📔 Objective

Creates a refreshed and consolidated LoginViaAuthRequestComponent for use on all visual clients, which will be used when the UnauthenticatedExtensionUIRefresh is on.

📸 Screenshots

Standard Login with Device

standard-login-with-device.mov

Admin Approval

admin-approval.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 1.91388% with 205 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@f771bd7). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...a-auth-request/login-via-auth-request.component.ts 0.00% 160 Missing ⚠️
.../services/auth-request/auth-request-api.service.ts 4.00% 24 Missing ⚠️
.../auth/login/login-via-auth-request-v1.component.ts 0.00% 3 Missing ⚠️
.../components/login-via-auth-request-v1.component.ts 0.00% 3 Missing ⚠️
.../auth/popup/login-via-auth-request-v1.component.ts 0.00% 2 Missing ⚠️
.../auth/login/login-via-auth-request-v1.component.ts 0.00% 2 Missing ⚠️
libs/auth/src/angular/icons/devices.icon.ts 0.00% 2 Missing ⚠️
apps/browser/src/popup/app-routing.module.ts 0.00% 1 Missing ⚠️
apps/browser/src/popup/app.module.ts 0.00% 1 Missing ⚠️
apps/desktop/src/app/app-routing.module.ts 0.00% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11545   +/-   ##
=======================================
  Coverage        ?   33.47%           
=======================================
  Files           ?     2816           
  Lines           ?    87618           
  Branches        ?    16711           
=======================================
  Hits            ?    29326           
  Misses          ?    55987           
  Partials        ?     2305           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 14, 2024

Logo
Checkmarx One – Scan Summary & Details237d5fb7-7c46-4fc7-ba03-5d35b408a5ee

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/login/login-via-auth-request-v1.component.ts: 61 Attack Vector
LOW Client_DOM_Open_Redirect /apps/browser/src/auth/popup/login-via-auth-request-v1.component.ts: 53 Attack Vector
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/login/login-via-auth-request-v1.component.ts: 61 Attack Vector
LOW Client_DOM_Open_Redirect /apps/browser/src/auth/popup/login-via-auth-request-v1.component.ts: 53 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /libs/tools/generator/components/src/credential-generator-history.component.html: 3
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 40
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 45
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 35
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 40
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 108
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 108
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 103
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 113
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/login/login-via-auth-request.component.ts: 61
LOW Client_DOM_Open_Redirect /apps/desktop/src/auth/login/login-via-auth-request.component.ts: 61
LOW Client_DOM_Open_Redirect /apps/browser/src/auth/popup/login-via-auth-request.component.ts: 53
LOW Client_DOM_Open_Redirect /apps/browser/src/auth/popup/login-via-auth-request.component.ts: 53
LOW Client_JQuery_Deprecated_Symbols /apps/cli/src/service-container/service-container.ts: 875

@rr-bw rr-bw marked this pull request as ready for review October 28, 2024 16:31
@rr-bw rr-bw requested a review from a team as a code owner October 28, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant