Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12765] - add subscription validation to member dialog #11783

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jaasen-livefront
Copy link
Collaborator

@jaasen-livefront jaasen-livefront commented Oct 29, 2024

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-12765

๐Ÿ“” Objective

This PR adds additional validation to the org member dialog to ensure the org has a valid subscription and before running any other validation like number of seats.

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@jaasen-livefront jaasen-livefront requested a review from a team as a code owner October 29, 2024 22:46
@jaasen-livefront jaasen-livefront requested review from BTreston and cturnbull-bitwarden and removed request for BTreston October 29, 2024 22:46
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 33.53%. Comparing base (b391c29) to head (4e7dd56).
Report is 2 commits behind head on main.

โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...omponents/member-dialog/member-dialog.component.ts 0.00% 7 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11783      +/-   ##
==========================================
- Coverage   33.54%   33.53%   -0.01%     
==========================================
  Files        2810     2810              
  Lines       87327    87336       +9     
  Branches    16657    16660       +3     
==========================================
+ Hits        29291    29292       +1     
- Misses      55739    55747       +8     
  Partials     2297     2297              

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant