Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14349] Collection of page details on websites with ShadowDOM elem… #11809

Conversation

cagonzalezcs
Copy link
Contributor

…ents might not capture form elements

🎟️ Tracking

https://bitwarden.atlassian.net/jira/software/c/projects/BW/boards/93?selectedIssue=PM-14349

📔 Objective

An issue has been identified with the work that was done to improve the performance of the page details collection process. It's possible that the injection of a ShadowDOM element that occurs after the page has loaded is not captured correctly. This leads to a situation where websites such as https://auth.max.com/login and https://www.royalcaribbean.com/account/signin do not present the inline menu or autofill correctly on their form field elements.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cagonzalezcs cagonzalezcs requested a review from a team as a code owner October 31, 2024 16:46
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 33.53%. Comparing base (2b6406c) to head (d53720f).
Report is 12 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ofill/services/collect-autofill-content.service.ts 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11809      +/-   ##
==========================================
- Coverage   33.53%   33.53%   -0.01%     
==========================================
  Files        2812     2812              
  Lines       87424    87428       +4     
  Branches    16674    16675       +1     
==========================================
+ Hits        29322    29323       +1     
- Misses      55797    55800       +3     
  Partials     2305     2305              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cagonzalezcs cagonzalezcs merged commit 227e9c4 into main Nov 1, 2024
25 of 26 checks passed
@cagonzalezcs cagonzalezcs deleted the autofill/pm-14349-collection-of-page-details-breaks-shadow-dom branch November 1, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants