-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-5237] Clients, Self Hosted: Login - Hide "Create account" when registration disabled #11811
base: main
Are you sure you want to change the base?
[PM-5237] Clients, Self Hosted: Login - Hide "Create account" when registration disabled #11811
Conversation
…bled' of https://github.com/bitwarden/clients into auth/pm-5237/hide-create-account-when-registration-disabled
@JaredSnider-Bitwarden would you mind taking a look at this and letting me know if I'm on the right track? One piece I haven't been able to work out is "The create account section should react to environment changes if a user changes from an env where open registration is enabled to one where it is disabled" - it seems I have to refresh the page to get it to pick up the latest config. |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11811 +/- ##
==========================================
+ Coverage 33.53% 33.54% +0.01%
==========================================
Files 2814 2816 +2
Lines 87464 87488 +24
Branches 16677 16679 +2
==========================================
+ Hits 29330 29351 +21
- Misses 55829 55832 +3
Partials 2305 2305 ☔ View full report in Codecov by Sentry. |
…s the same across all clients and to solve NullInjectorErrors on desktop & browser extension
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-5237?atlOrigin=eyJpIjoiYzc4ODNlZjM5Y2RiNDY5Njg5YmU5MjM3YjgwYjZjYTkiLCJwIjoiaiJ9
📔 Objective
Shows or hides the "create account" link based on the GlobalSettings configuration.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes