Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-5237] Clients, Self Hosted: Login - Hide "Create account" when registration disabled #11811

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

alec-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-5237?atlOrigin=eyJpIjoiYzc4ODNlZjM5Y2RiNDY5Njg5YmU5MjM3YjgwYjZjYTkiLCJwIjoiaiJ9

📔 Objective

Shows or hides the "create account" link based on the GlobalSettings configuration.

📸 Screenshots

Screenshot 2024-10-31 at 1 16 25 PM
Screenshot 2024-10-31 at 1 16 12 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@alec-livefront
Copy link
Collaborator Author

@JaredSnider-Bitwarden would you mind taking a look at this and letting me know if I'm on the right track? One piece I haven't been able to work out is "The create account section should react to environment changes if a user changes from an env where open registration is enabled to one where it is disabled" - it seems I have to refresh the page to get it to pick up the latest config.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 33.54%. Comparing base (5eae599) to head (d9931ed).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/web/src/app/auth/login/login-v1.component.ts 0.00% 6 Missing ⚠️
...angular/login/login-secondary-content.component.ts 0.00% 3 Missing ⚠️
libs/angular/src/services/jslib-services.module.ts 0.00% 1 Missing ⚠️
...platform/services/config/default-config.service.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11811      +/-   ##
==========================================
+ Coverage   33.53%   33.54%   +0.01%     
==========================================
  Files        2814     2816       +2     
  Lines       87464    87488      +24     
  Branches    16677    16679       +2     
==========================================
+ Hits        29330    29351      +21     
- Misses      55829    55832       +3     
  Partials     2305     2305              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alec-livefront alec-livefront changed the title Auth/pm 5237/hide create account when registration disabled [PM-5237} Clients, Self Hosted: Login - Hide "Create account" when registration disabled Oct 31, 2024
alec-livefront and others added 3 commits October 31, 2024 13:51
…s the same across all clients and to solve NullInjectorErrors on desktop & browser extension
@alec-livefront alec-livefront changed the title [PM-5237} Clients, Self Hosted: Login - Hide "Create account" when registration disabled [PM-5237] Clients, Self Hosted: Login - Hide "Create account" when registration disabled Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants