PM-13694: Set carousel shown prior to account setup screens (#1085)

bitwarden · Oct 28, 2024 · 4fa75b0 · 4fa75b0
1 parent 6580bec
commit 4fa75b0
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/BitwardenShared/UI/Auth/AuthRouterTests.swift b/BitwardenShared/UI/Auth/AuthRouterTests.swift
@@ -178,6 +178,21 @@ final class AuthRouterTests: BitwardenTestCase { // swiftlint:disable:this type_
         XCTAssertTrue(stateService.introCarouselShown)
     }
 
+    /// `handleAndRoute(_ :)` redirects `.didCompleteAuth` to `.vaultUnlockSetup` and sets the
+    /// carousel shown flag if the carousel feature flag is on and the carousel hasn't been shown yet.
+    @MainActor
+    func test_handleAndRoute_didCompleteAuth_carouselShown_vaultUnlockSetup() async {
+        authRepository.activeAccount = .fixture()
+        configService.featureFlagsBool[.nativeCarouselFlow] = true
+        stateService.activeAccount = .fixture()
+        stateService.accountSetupVaultUnlock["1"] = .incomplete
+
+        let route = await subject.handleAndRoute(.didCompleteAuth)
+
+        XCTAssertEqual(route, .vaultUnlockSetup(.createAccount))
+        XCTAssertTrue(stateService.introCarouselShown)
+    }
+
     /// `handleAndRoute(_:)` redirects `.didCompleteAuth` to complete the auth flow if the account
     /// doesn't require an updated password.
     func test_handleAndRoute_didCompleteAuth_complete() async {

diff --git a/BitwardenShared/UI/Auth/Extensions/AuthRouter+Redirects.swift b/BitwardenShared/UI/Auth/Extensions/AuthRouter+Redirects.swift
@@ -29,6 +29,8 @@ extension AuthRouter {
             return .landing
         }
 
+        await setCarouselShownIfEnabled()
+
         if account.profile.forcePasswordResetReason != nil {
             return .updateMasterPassword
         }
@@ -41,7 +43,6 @@ extension AuthRouter {
             }
         }
 
-        await setCarouselShownIfEnabled()
         return .complete
     }