BIT-2346: Additional tests and feedback

BitwardenShared/Core/Autofill/Services/AutofillCredentialServiceTests.swift

@@ -181,6 +181,30 @@ class AutofillCredentialServiceTests: BitwardenTestCase {
         XCTAssertNil(pasteboardService.copiedString)
     }
 
+    /// `provideCredential(for:)` copies the cipher's TOTP code if the user doesn't have premium
+    /// but the org uses TOTP.
+    func test_provideCredential_totpCopyOrgUseTotp() async throws {
+        cipherService.fetchCipherResult = .success(
+            .fixture(
+                login: .fixture(
+                    password: "password123",
+                    username: "[email protected]",
+                    totp: "totp"
+                ),
+                organizationUseTotp: true
+            )
+        )
+        stateService.activeAccount = .fixture()
+        stateService.doesActiveAccountHavePremiumResult = .success(false)
+        vaultTimeoutService.isClientLocked["1"] = false
+
+        let credential = try await subject.provideCredential(for: "1", repromptPasswordValidated: false)
+
+        XCTAssertEqual(credential.password, "password123")
+        XCTAssertEqual(credential.user, "[email protected]")
+        XCTAssertEqual(pasteboardService.copiedString, "123456")
+    }
+
     /// `provideCredential(for:)` throws an error if the user's vault is locked.
     func test_provideCredential_vaultLocked() async {
         stateService.activeAccount = .fixture()

BitwardenShared/Core/Platform/Services/StateServiceTests.swift

@@ -162,7 +162,6 @@ class StateServiceTests: BitwardenTestCase { // swiftlint:disable:this type_body
     func test_doesActiveAccountHavePremium_personalFalse_organizationTrue() async throws {
         await subject.addAccount(.fixture(profile: .fixture(hasPremiumPersonally: false)))
         try await dataStore.replaceOrganizations([.fixture(usersGetPremium: true)], userId: "1")
-        let organizations = try await dataStore.fetchAllOrganizations(userId: "1")
         let hasPremium = try await subject.doesActiveAccountHavePremium()
         XCTAssertTrue(hasPremium)
     }
@@ -194,6 +193,15 @@ class StateServiceTests: BitwardenTestCase { // swiftlint:disable:this type_body
         XCTAssertFalse(hasPremium)
     }
 
+    /// `doesActiveAccountHavePremium()` with no premium personally and an organization with premium
+    /// for a different user returns false.
+    func test_doesActiveAccountHavePremium_personalFalse_organizationTrueForOtherUser() async throws {
+        await subject.addAccount(.fixture(profile: .fixture(hasPremiumPersonally: false)))
+        try await dataStore.replaceOrganizations([.fixture(enabled: true, usersGetPremium: true)], userId: "2")
+        let hasPremium = try await subject.doesActiveAccountHavePremium()
+        XCTAssertFalse(hasPremium)
+    }
+
     /// `getAccountEncryptionKeys(_:)` returns the encryption keys for the user account.
     func test_getAccountEncryptionKeys() async throws {
         appSettingsStore.encryptedPrivateKeys["1"] = "1:PRIVATE_KEY"