Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10401] Implemented SSH Key type handling #1092

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Oct 30, 2024

🎟️ Tracking

PM-10401

Server: bitwarden/server#4575

📔 Objective

Implement SSH key cipher type handling now that it has been added to the Bitwarden SDK. Also to show it in the Vault load and searches if the SSH key vault item feature flag is enabled.

📸 Screenshots

SSH Key type in vault

SSH Key type in vault

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

…vault if the SSH key feature flag is enabled.
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.35%. Comparing base (e02d571) to head (7c360c7).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1092   +/-   ##
=======================================
  Coverage   89.34%   89.35%           
=======================================
  Files         677      677           
  Lines       42761    42800   +39     
=======================================
+ Hits        38205    38244   +39     
  Misses       4556     4556           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fedemkr fedemkr merged commit b4df4c6 into main Oct 31, 2024
9 checks passed
@fedemkr fedemkr deleted the pm-10401/ssh-key-type-handling branch October 31, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants