PM-12664 - Update Bottom Navigation Across All Screens

[phil-livefront]

🎟️ Tracking

PM-12664

📔 Objective

• Implemented a custom BitwardenTabBarController to manage dynamic light/dark mode icon updates.
• UIKit doesn't dynamically update tab bar images with multiple active colors for selected icons, even thought it does adjust the color. To support our new icons with two active colors when selected, we must use the original image rather than a template.
• In idle state, icons continue to use the template image, allowing standard system adaption.
• The new tab bar controller overrides traitCollectionDidChange, allowing the tabs to refresh when the theme changes mid-session. This approach supports theme adjustments through OS settings, Control Center, and the Bitwarden app internal settings as well.

📸 Screenshots

ScreenRecording_10-30-2024.16-38-58_1.MP4

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.37%. Comparing base (bc0356a) to head (af83ecf).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1093   +/-   ##
=======================================
  Coverage   89.36%   89.37%           
=======================================
  Files         677      677           
  Lines       42817    42862   +45     
=======================================
+ Hits        38262    38306   +44     
- Misses       4555     4556    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fedemkr]

⚠️ This breaks in Xcode 16 as iOS18 introduces a tabs property in UITabBarController

[phil-livefront]

oh good catch! thanks Federico!