Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14367] Update default base_version_number in build.yml #1098

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

vvolkgang
Copy link
Member

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-14367

๐Ÿ“” Objective

Matching the base version number of CI-main.yml, making it easier to trigger manual builds following the same number sequence.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang requested a review from a team as a code owner October 31, 2024 19:49
@vvolkgang vvolkgang changed the title [PM-14367] Update default base_version_number in build.yml to match ci-main.yml [PM-14367] Update default base_version_number Oct 31, 2024
@vvolkgang vvolkgang changed the title [PM-14367] Update default base_version_number [PM-14367] Update default base_version_number in build.yml Oct 31, 2024
@vvolkgang vvolkgang enabled auto-merge (squash) October 31, 2024 19:49
@vvolkgang vvolkgang merged commit c182493 into main Oct 31, 2024
7 checks passed
@vvolkgang vvolkgang deleted the vvolkgang-patch-1 branch October 31, 2024 20:00
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Please upload report for BASE (main@15e1e8e). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1098   +/-   ##
=======================================
  Coverage        ?   89.34%           
=======================================
  Files           ?      677           
  Lines           ?    42763           
  Branches        ?        0           
=======================================
  Hits            ?    38207           
  Misses          ?     4556           
  Partials        ?        0           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants