BIT-1212: Nested Folder Support #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bitwarden code coverageTotal coverage:
|
| File | Coverage |
|---|---|
| BitwardenShared/Core/Platform/Utilities/Tree.swift | 100.00% |
| BitwardenShared/Core/Vault/Extensions/BitwardenSdk+Vault.swift | 62.37% |
| BitwardenShared/Core/Vault/Repositories/VaultRepository.swift | 96.57% |
| BitwardenShared/UI/Vault/Vault/VaultList/VaultListGroup.swift | 98.33% |
Powered by Slather
Generated by 🚫 Danger
| /// - Returns: A list of items for the group in the vault list. | ||
| /// | ||
| private func vaultListItems( | ||
| private func vaultListItems( // swiftlint:disable:this function_body_length |
There was a problem hiding this comment.
🎨 : Instead of disabling the swiftlint warning on length here, would it be possible to put some of the functionality into a separate private method, and make this smaller as a result? In particular, could the calculation of folderSection be split out?
There was a problem hiding this comment.
Yep, good callout, updated!
matt-livefront
force-pushed
the
matt/BIT-1212-nested-folders
branch
from
0aba570
to
9590564
Compare
|
No New Or Fixed Issues Found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
BIT-1212
🚧 Type of change
📔 Objective
Adds support for nested folders.
📋 Code changes
📸 Screenshots
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-14.at.16.45.37.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes