BIT-2076: Take minimum password length into account with slider

[KatherineInCode]

🎟️ Tracking

BIT-2076 - Generator Minimum Length Pop Up Error Behavior

🚧 Type of change

• 🐛 Bug fix

📔 Objective

In the event that a user did not have an enterprise policy enforcing a minimum password limit but had their own constraints that meant a higher minimum password length, it was possible to move the password generator length slider in such a way that it would try to generate a password under the minimum password length, causing an error.

This fix obviates that problem by making the slider take into account the user's chosen minimum password length.

Another fix discussed was to include a Task.checkCancellation() before generating the password, but doing that had other effects on the tests that might be harder to work around.

📋 Code changes

• GeneratorState+PasswordState.swift: Move the calculation of minimum length based on constraints into a calculated property
• GeneratorState.swift: Factor in the minimum length based on constraints when determining if the length slider should move

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

	1 Warning
⚠️	Ignoring duplicate libraries: '-lbitwarden_uniffi'

Bitwarden code coverage

Total coverage: 86.36%

File	Coverage
BitwardenShared/UI/Tools/Generator/Generator/GeneratorState+PasswordState.swift	100.00%
BitwardenShared/UI/Tools/Generator/Generator/GeneratorState.swift	99.70%

Powered by Slather

Generated by 🚫 Danger

[bitwarden-bot]

Checkmarx One – Scan Summary & Details – 51fb8fb4-b4ed-404a-887b-50b43d75e6da

No New Or Fixed Issues Found

[matt-livefront]

Looks good!