Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIT-273: Rename old unit tests to follow standard #538

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

KatherineInCode
Copy link
Contributor

🎟️ Tracking

BIT-273 - Rename all of the unit tests in Networking to follow our new unit test naming scheme

🚧 Type of change

  • 🧹 Tech debt (refactoring, code cleanup, dependency upgrades, etc.)

📔 Objective

Various unit tests were named with camel case (testInit), while the standard in the codebase is underscores between camel case components (test_init). This unifies all the old tests to that new standard

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

1 Warning
⚠️ Ignoring duplicate libraries: '-lbitwarden_uniffi'

Bitwarden code coverage

Total coverage: 86.33%

Powered by Slather

Generated by 🚫 Danger

@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Detailsa3d18e7d-bbef-42d1-9a95-fa1e7a11d623

No New Or Fixed Issues Found

Copy link
Collaborator

@matt-livefront matt-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@KatherineInCode KatherineInCode merged commit 38864e2 into main Mar 20, 2024
6 checks passed
@KatherineInCode KatherineInCode deleted the kbertelsen/BIT-273-rename-old-tests branch March 20, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants