Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIT-2304: Fix pin unlock for new TDE accounts #626

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

matt-livefront
Copy link
Collaborator

๐ŸŽŸ๏ธ Tracking

BIT-2304

๐Ÿ“” Objective

This fixes an issue where pin unlock fails for new TDE accounts. The user's encrypted private key needs to be persisted after the account is created to enable pin unlock to work.

๐Ÿ“ธ Screenshots

Before After
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-04-30.at.11.51.19.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-04-30.at.11.49.38.mp4

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

1 Warning
โš ๏ธ Ignoring duplicate libraries: '-lbitwarden_uniffi'

Bitwarden code coverage

Total coverage: 86.46%

File Coverage
BitwardenShared/Core/Auth/Repositories/AuthRepository.swift 97.12%

Powered by Slather

Generated by ๐Ÿšซ Danger

@matt-livefront matt-livefront merged commit 1006023 into main Apr 30, 2024
4 of 5 checks passed
@matt-livefront matt-livefront deleted the matt/BIT-2304-tde-pin-unlock branch April 30, 2024 17:13
@bitwarden-bot
Copy link

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ ddae6d68-2827-4615-a3e8-8816f990b5c0

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants