Allow feature flag state configuration via application settings (#2963)

* Allow feature flag state configuration via application settings * Use string values for flags * Update src/Core/Services/Implementations/LaunchDarklyFeatureService.cs Remove useless `ToString()`. Co-authored-by: Justin Baur <[email protected]> --------- Co-authored-by: Justin Baur <[email protected]>
bitwarden · May 26, 2023 · beb3479 · beb3479
1 parent 5079c2b
commit beb3479
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 3 deletions.
diff --git a/src/Core/Services/Implementations/LaunchDarklyFeatureService.cs b/src/Core/Services/Implementations/LaunchDarklyFeatureService.cs
@@ -25,15 +25,37 @@ public LaunchDarklyFeatureService(
                         .FilePaths(globalSettings.LaunchDarkly?.FlagDataFilePath)
                         .AutoUpdate(true)
                 );
+            }
+            // support configuration directly from settings
+            else if (globalSettings.LaunchDarkly?.FlagValues?.Any() is true)
+            {
+                var source = TestData.DataSource();
+                foreach (var kvp in globalSettings.LaunchDarkly.FlagValues)
+                {
+                    if (bool.TryParse(kvp.Value, out bool boolValue))
+                    {
+                        source.Update(source.Flag(kvp.Key).ValueForAll(LaunchDarkly.Sdk.LdValue.Of(boolValue)));
+                    }
+                    else if (int.TryParse(kvp.Value, out int intValue))
+                    {
+                        source.Update(source.Flag(kvp.Key).ValueForAll(LaunchDarkly.Sdk.LdValue.Of(intValue)));
+                    }
+                    else
+                    {
+                        source.Update(source.Flag(kvp.Key).ValueForAll(LaunchDarkly.Sdk.LdValue.Of(kvp.Value)));
+                    }
+                }
 
-                // do not provide analytics events
-                ldConfig.Events(Components.NoEvents);
+                ldConfig.DataSource(source);
             }
             else
             {
-                // when a file-based fallback isn't available, work offline
+                // when fallbacks aren't available, work offline
                 ldConfig.Offline(true);
             }
+
+            // do not provide analytics events
+            ldConfig.Events(Components.NoEvents);
         }
         else if (globalSettings.SelfHosted)
         {

diff --git a/src/Core/Settings/GlobalSettings.cs b/src/Core/Settings/GlobalSettings.cs
@@ -545,5 +545,6 @@ public class LaunchDarklySettings : ILaunchDarklySettings
     {
         public string SdkKey { get; set; }
         public string FlagDataFilePath { get; set; } = "flags.json";
+        public Dictionary<string, string> FlagValues { get; set; } = new Dictionary<string, string>();
     }
 }
diff --git a/src/Core/Settings/ILaunchDarklySettings.cs b/src/Core/Settings/ILaunchDarklySettings.cs
@@ -4,4 +4,5 @@ public interface ILaunchDarklySettings
 {
     public string SdkKey { get; set; }
     public string FlagDataFilePath { get; set; }
+    public Dictionary<string, string> FlagValues { get; set; }
 }