Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-1487] Fix missing Admin Auth Request emails #3083

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

shane-melton
Copy link
Member

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Update the TDE admin auth request SQL queries to use the [User] table for the email address instead of the [OrganizationUser] table, which does not always have an email available.

Code changes

Update the AuthRequest_ReadAdminApprovalsbyIds.sql and AuthRequest_ReadPendingByOrganizationId.sql scripts to join on the [User] table in order to retrieve the user's email address.

Also adds the necessary migration script.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@shane-melton shane-melton requested a review from a team as a code owner July 10, 2023 22:57
@bitwarden-bot
Copy link

bitwarden-bot commented Jul 10, 2023

Logo
Checkmarx One – Scan Summary & Detailsb273c835-2ebd-4c9e-b453-5d037fb6dd48

No New Or Fixed Issues Found

Copy link
Member

@justindbaur justindbaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@vincentsalucci
Copy link
Member

Removing the needs-qa tag for merging into master and pulling in latest changes for further QA testing on feature/trusted-device-encryption

@vincentsalucci vincentsalucci merged commit fe570cb into master Jul 17, 2023
2 checks passed
@vincentsalucci vincentsalucci deleted the ac/ac-1487/missing-admin-auth-request-email branch July 17, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants