[AC-2568] Added invoices and transaction history endpoints. Added cursor paging for each #4692

cturnbull-bitwarden · 2024-08-23T14:06:35Z

🎟️ Tracking

https://bitwarden.atlassian.net/browse/AC-2568

📔 Objective

Added invoices and transaction history endpoints. Added cursor paging for each

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

… for each

codecov · 2024-08-23T14:14:50Z

Codecov Report

Attention: Patch coverage is 25.21008% with 89 lines in your changes missing coverage. Please review.

Project coverage is 41.83%. Comparing base (ebf8bc0) to head (87f2fcb).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...lling/Controllers/OrganizationBillingController.cs	6.66%	28 Missing ⚠️
...i/Billing/Controllers/AccountsBillingController.cs	0.00%	24 Missing ⚠️
...cture.Dapper/Repositories/TransactionRepository.cs	0.00%	23 Missing ⚠️
...ityFramework/Repositories/TransactionRepository.cs	0.00%	12 Missing ⚠️
.../Services/Implementations/PaymentHistoryService.cs	92.59%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #4692    +/-   ##
========================================
  Coverage   41.82%   41.83%            
========================================
  Files        1293     1294     +1     
  Lines       61632    61740   +108     
  Branches     5681     5693    +12     
========================================
+ Hits        25778    25827    +49     
- Misses      34664    34722    +58     
- Partials     1190     1191     +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-08-23T14:32:31Z

Checkmarx One – Scan Summary & Details – c8c10694-dedd-4d63-aca0-ecb78de9de9c

New Issues

Issue	Source File / Package	Checkmarx Insight
Privacy_Violation	/src/Api/Auth/Controllers/TwoFactorController.cs: 488	Attack Vector
Privacy_Violation	/src/Api/Controllers/DevicesController.cs: 133	Attack Vector
Privacy_Violation	/src/Api/Auth/Controllers/AccountsController.cs: 412	Attack Vector
Privacy_Violation	/src/Api/Auth/Controllers/AccountsController.cs: 549	Attack Vector
Privacy_Violation	/src/Api/Vault/Controllers/CiphersController.cs: 906	Attack Vector
Privacy_Violation	/src/Api/Auth/Controllers/AccountsController.cs: 847	Attack Vector
Privacy_Violation	/src/Api/Auth/Controllers/AccountsController.cs: 829	Attack Vector
Privacy_Violation	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 259	Attack Vector
Privacy_Violation	/src/Api/Controllers/DevicesController.cs: 159	Attack Vector
Privacy_Violation	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 350	Attack Vector
Privacy_Violation	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 403	Attack Vector
Log_Forging	/src/Billing/Controllers/StripeController.cs: 164	Attack Vector
Log_Forging	/src/Billing/Controllers/StripeController.cs: 164	Attack Vector
Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 217	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 412	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 423	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 445	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/AccountsController.cs: 839	Attack Vector
Log_Forging	/src/Api/Vault/Controllers/CiphersController.cs: 898	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 103	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 118	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 165	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 174	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 191	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 200	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 231	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 249	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 288	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 297	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 306	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 323	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 332	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 340	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/TwoFactorController.cs: 393	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/AccountsController.cs: 404	Attack Vector
Log_Forging	/src/Api/Controllers/DevicesController.cs: 124	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/AccountsController.cs: 541	Attack Vector
Log_Forging	/src/Api/Auth/Controllers/AccountsController.cs: 821	Attack Vector
Log_Forging	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 239	Attack Vector
Log_Forging	/src/Api/Controllers/DevicesController.cs: 150	Attack Vector
Log_Forging	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 378	Attack Vector
Log_Forging	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 315	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 107
	CSRF	/src/Api/Controllers/DevicesController.cs: 74
	CSRF	/src/Api/Controllers/DevicesController.cs: 61
	CSRF	/src/Api/AdminConsole/Public/Controllers/MembersController.cs: 98
	CSRF	/src/Api/Auth/Controllers/TwoFactorController.cs: 118
	CSRF	/src/Api/AdminConsole/Public/Controllers/MembersController.cs: 98
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 229
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 478
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 551
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 283
	CSRF	/src/Api/Billing/Public/Controllers/OrganizationController.cs: 47
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 176
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 445
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 503
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationsController.cs: 478
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 565
	CSRF	/src/Api/AdminConsole/Public/Controllers/OrganizationController.cs: 43
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 357
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 337
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 107
	CSRF	/src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 255
	CSRF	/src/Api/Controllers/DevicesController.cs: 61
	CSRF	/src/Api/Controllers/DevicesController.cs: 74
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 676
	Privacy_Violation	/src/Core/Auth/UserFeatures/TdeOffboardingPassword/TdeOffboardingPasswordCommand.cs: 81
	Privacy_Violation	/src/Core/Auth/UserFeatures/TdeOffboardingPassword/TdeOffboardingPasswordCommand.cs: 81
	Privacy_Violation	/src/Core/Auth/UserFeatures/UserMasterPassword/SetInitialMasterPasswordCommand.cs: 59
	Privacy_Violation	/src/Core/Auth/UserFeatures/UserMasterPassword/SetInitialMasterPasswordCommand.cs: 59
	Log_Forging	/src/Api/AdminConsole/Controllers/ProvidersController.cs: 72
	Log_Forging	/src/Api/Auth/Controllers/AccountsController.cs: 882
	Log_Forging	/src/Api/Auth/Controllers/AccountsController.cs: 246
	Log_Forging	/src/Api/Auth/Controllers/AccountsController.cs: 366

cyprain-okeke

Looks Good

amorask-bitwarden

Just a few ⛏️s, but all looks good to me. Do you think it's worth adding some unit tests for the new service? Could also add controller tests, but the action methods are pretty simple so I'm not worried about them.

src/Core/Billing/Services/Implementations/PaymentHistoryService.cs

… to use pattern matching

rkac-bw

lgtm

# Conflicts: # src/Api/Billing/Controllers/OrganizationBillingController.cs

rkac-bw

lgtm

Added invoices and transaction history endpoints. Added cursor paging…

a987516

… for each

cturnbull-bitwarden requested review from a team as code owners August 23, 2024 14:06

cyprain-okeke previously approved these changes Aug 23, 2024

View reviewed changes

amorask-bitwarden reviewed Aug 23, 2024

View reviewed changes

src/Core/Billing/Services/Implementations/PaymentHistoryService.cs Outdated Show resolved Hide resolved

src/Core/Billing/Services/Implementations/PaymentHistoryService.cs Outdated Show resolved Hide resolved

cturnbull-bitwarden added 2 commits August 23, 2024 12:01

Removed try/catch since it's handled by middleware. Updated condition…

41c7257

… to use pattern matching

Added unit tests for PaymentHistoryService

41c348d

cturnbull-bitwarden dismissed cyprain-okeke’s stale review via 41c348d August 23, 2024 16:03

amorask-bitwarden previously approved these changes Aug 23, 2024

View reviewed changes

rkac-bw previously approved these changes Aug 23, 2024

View reviewed changes

bitwarden-devops-bot temporarily deployed to EU-QA Cloud September 3, 2024 17:22 Inactive

Merge branch 'main' into billing/AC-2568/invoice-pagination

d76fdbe

# Conflicts: # src/Api/Billing/Controllers/OrganizationBillingController.cs

cturnbull-bitwarden dismissed stale reviews from rkac-bw and amorask-bitwarden via d76fdbe September 3, 2024 17:52

Removed organizationId from account billing controller endpoints

7bb82a1

cturnbull-bitwarden requested review from amorask-bitwarden and rkac-bw September 3, 2024 17:58

bitwarden-devops-bot temporarily deployed to EU-QA Cloud September 3, 2024 19:01 Inactive

bitwarden-devops-bot temporarily deployed to EU-QA Cloud September 6, 2024 20:14 Inactive

Merge branch 'main' into billing/AC-2568/invoice-pagination

87f2fcb

amorask-bitwarden approved these changes Sep 9, 2024

View reviewed changes

rkac-bw approved these changes Sep 9, 2024

View reviewed changes

cturnbull-bitwarden merged commit 46ac2a9 into main Sep 9, 2024
53 of 54 checks passed

cturnbull-bitwarden deleted the billing/AC-2568/invoice-pagination branch September 9, 2024 13:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AC-2568] Added invoices and transaction history endpoints. Added cursor paging for each #4692

[AC-2568] Added invoices and transaction history endpoints. Added cursor paging for each #4692

cturnbull-bitwarden commented Aug 23, 2024

codecov bot commented Aug 23, 2024 •

edited

Loading

github-actions bot commented Aug 23, 2024 •

edited

Loading

cyprain-okeke left a comment

amorask-bitwarden left a comment

rkac-bw left a comment

rkac-bw left a comment

[AC-2568] Added invoices and transaction history endpoints. Added cursor paging for each #4692

[AC-2568] Added invoices and transaction history endpoints. Added cursor paging for each #4692

Conversation

cturnbull-bitwarden commented Aug 23, 2024

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

🦮 Reviewer guidelines

codecov bot commented Aug 23, 2024 • edited Loading

Codecov Report

github-actions bot commented Aug 23, 2024 • edited Loading

New Issues

Fixed Issues

cyprain-okeke left a comment

Choose a reason for hiding this comment

amorask-bitwarden left a comment

Choose a reason for hiding this comment

rkac-bw left a comment

Choose a reason for hiding this comment

rkac-bw left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 23, 2024 •

edited

Loading

github-actions bot commented Aug 23, 2024 •

edited

Loading