Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11864] Bumped the dates on the transaction scripts so that QA deployment will pick them up #4764

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

cturnbull-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11864

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cturnbull-bitwarden cturnbull-bitwarden requested a review from a team as a code owner September 11, 2024 15:31
Copy link
Contributor

@rkac-bw rkac-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cturnbull-bitwarden cturnbull-bitwarden merged commit bee7673 into main Sep 11, 2024
45 of 48 checks passed
@cturnbull-bitwarden cturnbull-bitwarden deleted the billing/PM-11864/db-script-date-bump branch September 11, 2024 15:37
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.71%. Comparing base (68b421f) to head (509cb4f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4764   +/-   ##
=======================================
  Coverage   41.71%   41.71%           
=======================================
  Files        1308     1308           
  Lines       61986    61986           
  Branches     5707     5707           
=======================================
  Hits        25855    25855           
  Misses      34940    34940           
  Partials     1191     1191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cturnbull-bitwarden added a commit that referenced this pull request Sep 11, 2024
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details68704426-fe5b-4566-980f-c0f52cb20c4c

No New Or Fixed Issues Found

@Larry-Sussman Larry-Sussman changed the title Bumped the dates on the transaction scripts so that QA deployment will pick them up [PM-11864] Bumped the dates on the transaction scripts so that QA deployment will pick them up Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants