Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRE-344 - Add PR logic to Repository Management workflow #4938

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

vgrassia
Copy link
Member

🎟️ Tracking

📔 Objective

This PR adds pull request logic to the Repository Management workflow. This takes care of the issue of pushing to main which is protected.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vgrassia vgrassia requested a review from a team October 24, 2024 17:43
@vgrassia vgrassia self-assigned this Oct 24, 2024
@vgrassia vgrassia enabled auto-merge (squash) October 24, 2024 17:46
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.48%. Comparing base (0c346d6) to head (865f5f4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4938      +/-   ##
==========================================
+ Coverage   42.36%   42.48%   +0.12%     
==========================================
  Files        1385     1386       +1     
  Lines       64604    64648      +44     
  Branches     5936     5934       -2     
==========================================
+ Hits        27367    27466      +99     
+ Misses      36006    35955      -51     
+ Partials     1231     1227       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 24, 2024

Logo
Checkmarx One – Scan Summary & Details842a00db-3fae-4229-8827-74364989b099

No New Or Fixed Issues Found

@vgrassia vgrassia merged commit 9a499df into main Oct 24, 2024
52 checks passed
@vgrassia vgrassia deleted the bre-344_update-repository-management-workflow branch October 24, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants