[PM-13014] - Add CanToggleStatus property to PolicyRepsonseModel based on Policy Validators #4940
+92
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Added mappings wrapped in feature flag.
… same type of policy validator into its DI.
|
New Issues
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4940 +/- ##
=======================================
Coverage 42.56% 42.57%
=======================================
Files 1387 1389 +2
Lines 64653 64678 +25
Branches 5936 5940 +4
=======================================
+ Hits 27521 27536 +15
- Misses 35908 35916 +8
- Partials 1224 1226 +2 ☔ View full report in Codecov by Sentry. |
eliykat
requested changes
Oct 25, 2024
...Core/AdminConsole/OrganizationFeatures/Policies/PolicyValidators/SingleOrgPolicyValidator.cs
Outdated
Show resolved
Hide resolved
…om List endpoint. Added new details model for single policy response. Validator now returns after first error.
# Conflicts: # src/Api/AdminConsole/Controllers/PoliciesController.cs
eliykat
requested changes
Nov 1, 2024
| throw new ArgumentException($"'{nameof(policy)}' must be of type '{nameof(PolicyType.SingleOrg)}'.", nameof(policy)); | ||
| } | ||
|
|
||
| return new PolicyDetailResponseModel(policy, await hasVerifiedDomainsQuery.HasVerifiedDomainsAsync(policy.OrganizationId)); |
There was a problem hiding this comment.
I think the bool needs to be inverted:
- has verified domains => can't toggle state
- does not have verified domains => can toggle state
(Probably a drawback of a bool that defaults to true, I didn't realise that when I suggested the naming. But no need to spend more time on it.)
There was a problem hiding this comment.
No changes required, but I am interested in the decision to use an extension method here vs. a static method on the class itself. I can make some guesses but would like to hear your thoughts.
There was a problem hiding this comment.
Api request/response models live in the Api project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-13014
📔 Objective
This will add a
CanToggleStatusflag to thePolicyResponseModelto inform clients on whether or not they will be allowed to change the status of the policy (enable/disable). This is using the newPolicyValidator#ValidateAsyncmethods to determine if it can be changed. This is limited toSingle Org Policyfor now.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes