Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace AuthAccountProvider by AuthAccountAdapter #110

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Replace AuthAccountProvider by AuthAccountAdapter #110

merged 3 commits into from
Nov 2, 2023

Conversation

bivashy
Copy link
Owner

@bivashy bivashy commented Oct 31, 2023

Changes

  • Internal code
  • API (affecting end-user code)
  • Other

Description

This pull request aims to replace dirty hacks like AuthAccountProvider, which leads to confusion in the future.

Partially makes it easier to implement migration from other plugins, because now it doesn't require AuthAccountProvider.

@bivashy bivashy added the status: needs testing Issue or PR should be tested label Oct 31, 2023
@bivashy bivashy removed the status: needs testing Issue or PR should be tested label Nov 2, 2023
@bivashy
Copy link
Owner Author

bivashy commented Nov 2, 2023

I've tested it, seems ok. I didn't experience any errors

@bivashy bivashy marked this pull request as ready for review November 2, 2023 16:17
@bivashy bivashy merged commit 17a0d9a into main Nov 2, 2023
3 checks passed
@bivashy bivashy deleted the refactor/less-depend-on-auth-account-provider branch November 2, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bivashy