Fix for PIP Inspector not working when pkg_resources package is not available in newer Python versions #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vailable in newer Python versions
andrian-sevastyanov
requested review from
gopannabd,
dterrysynopsys,
shantyk,
niravrsynopsys and
devmehtabd
src/main/resources/pip-inspector.py
Outdated
| dependency_node = DependencyNode(metadata["Name"], metadata["Version"]) | ||
|
|
||
| requirement_names = [] | ||
| requirements = importlib.metadata.requires(dependency_node.name) |
There was a problem hiding this comment.
I discovered a problem with this approach of listing dependencies since the requires() function can return packages which are not necessarily installed: in cases when the dependency is an "extra" or condition such as platform_python_implementation != 'PyPy' is evaluated to False.
I am currently exploring possible ways of filtering out such dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for PIP Inspector not working when pkg_resources package is not available in newer Python versions
Description
Starting with Python version 3.12 the PIP inspector fails out of the box with error
ModuleNotFoundError: No module named 'pkg_resources'.This could have been addressed by suggesting to customers to pre-install the missing package; however, this PR instead attempts to rely on newer
importlib.metadatapackage for the following reasons: