Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for multiple OS families #1476

Merged
merged 37 commits into from
Oct 22, 2024
Merged

Tests for multiple OS families #1476

merged 37 commits into from
Oct 22, 2024

Conversation

TheTechromancer
Copy link
Collaborator

@TheTechromancer TheTechromancer commented Jun 18, 2024

Addresses #1469.

Tests these Linux distros:

  • Ubuntu 20.04
  • Ubuntu 22.04
  • Ubuntu 24.04
  • Debian
  • Arch Linux
  • Fedora
  • Gentoo
  • Alpine
  • Kali
  • ParrotOS

Uses pyenv to install the latest python3.11.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 93%. Comparing base (6250877) to head (73b00f4).
Report is 42 commits behind head on dev.

Files with missing lines Patch % Lines
bbot/test/test_step_2/module_tests/base.py 50% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #1476   +/-   ##
=====================================
+ Coverage     93%     93%   +1%     
=====================================
  Files        354     354           
  Lines      27456   27458    +2     
=====================================
+ Hits       25315   25329   +14     
+ Misses      2141    2129   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer
Copy link
Collaborator Author

@domwhewell-sage we've run into a potential issue with these tests. In order to test BBOT on multiple OS families, we need to run the tests inside a docker container. This will cause the dastardly tests to fail, since we can't do docker-in-docker.

🤔🤔

@domwhewell-sage
Copy link
Contributor

Do you think it would be possible to add this to the dastardly test

@pytest.mark.skipif(not subprocess.run(['docker', '--version'], capture_output=True).returncode == 0,
                    reason="Docker is not installed")

@TheTechromancer
Copy link
Collaborator Author

Hmm I guess we could exclude it from the os family tests, but modules like dastardly with big dependencies are the reason we need those tests to begin with.

I'll see about excluding it for now, and maybe we can figure out a better solution further down the road.

@TheTechromancer TheTechromancer merged commit cda7d50 into dev Oct 22, 2024
12 of 16 checks passed
@TheTechromancer TheTechromancer deleted the multi-distro-tests branch October 28, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants