Fix: CMSIS-DAP transfer failure handling #1564
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
While helping Sid debug some really curious target behaviour from the Ambiq Apollo SoC's, he ran into an issue where ORBTrace would report the device gave a no-response response to a DAP_TRANSFER and BMDA would fail to pick up on that, pretending the DP register read worked just fine and gave a response of 0.
This PR corrects this behaviour by improving the perform_dap_transfer() error handling, allowing the detection of sequences such as
With this change, the request will by noted as having triggered no-response and dap_dp_reg_read() will attempt to perform protocol recovery and re-try the read.
Your checklist for this pull request
make PROBE_HOST=native
)make PROBE_HOST=hosted
)Closing issues