Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stm32u5 support #1574

Merged
merged 2 commits into from
Jul 30, 2023
Merged

Stm32u5 support #1574

merged 2 commits into from
Jul 30, 2023

Conversation

jcamdr
Copy link
Contributor

@jcamdr jcamdr commented Jul 28, 2023

Detailed description

Addition of the documentation reference for the STM32U5.
Addition of the DP_TARGETIDR id for the STM32U5.
Addition of the stm32l4_device_info for the STM32U5.
Addition of the RAM map for the STM32U5.

Your checklist for this pull request

  • I've read the Code of Conduct
  • I've read the guidelines for contributing to this repository
  • It builds for hardware native (make PROBE_HOST=native)
  • It builds as BMDA (make PROBE_HOST=hosted)
  • I've tested it to the best of my ability
  • My commit messages provide a useful short description of what the commits do

Closing issues

@dragonmux dragonmux added this to the v1.10 milestone Jul 29, 2023
@dragonmux dragonmux added the New Target New debug target label Jul 29, 2023
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, there's just one tweak that needs making and when done we can then merge this. Thank you for the contribution!

src/target/stm32l4.c Outdated Show resolved Hide resolved
@jcamdr jcamdr requested a review from dragonmux July 30, 2023 07:26
@jcamdr
Copy link
Contributor Author

jcamdr commented Jul 30, 2023

I will agree if you ask me to integrate the change request into the second commit. I was not so confident that the operation proposed by the github interface will do that or not.

@dragonmux
Copy link
Member

Yes, please do - sorry, meant to get back to this PR earlier and ask you to do just that. With that change made part of the second commit, we're happy to mark as accepted and merge this

@jcamdr
Copy link
Contributor Author

jcamdr commented Jul 30, 2023

Don't worry, it's part of the normal learning curve for working together.

Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, merging.

@dragonmux dragonmux merged commit 17e3f88 into blackmagic-debug:main Jul 30, 2023
6 checks passed
@jcamdr
Copy link
Contributor Author

jcamdr commented Jul 31, 2023

Thank you!
I will now think about the flash, the biggest part.

@dragonmux dragonmux linked an issue Oct 18, 2023 that may be closed by this pull request
@dragonmux dragonmux linked an issue Oct 21, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Target New debug target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on STM32U575ZIT6Q MCU Cortex-M33 support debugging stm32u5
2 participants