Fix: BMDA J-Link set frequency regression #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lly using the old divisor value
dragonmux
added
Bug
perigoso
approved these changes
Jul 29, 2023
|
Thank you for the help you provided figuring out what was wrong exactly, it was invaluable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
While testing an unrelated patch set with our LPC-Link 2 running the J-Link firmware, we discovered a firmware-crashing regression from Perigoso's PR #1570 which revolves around how the adaptor frequency is set.
This PR addresses this and a couple of clang-tidy and naming lints spotted along the way.
Your checklist for this pull request
make PROBE_HOST=native)make PROBE_HOST=hosted)Closing issues