-
-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: -Wformat for tc_printf #1828
Conversation
1169229
to
8af2037
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've got just the one review item - nice work! With that addressed, we think this will be ready for merge.
Our only other request is a tweak to the commit message - because it touches so much of the code base, please use the suffix misc:
, as in misc: Fixes for tc_printf invocations to enable -Wformat
Just a note that, once the remaining review notes have been taken care of, we're happy for this PR to be merged if it could be rebased on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't see any remaining review comments that need addressing, and it all LGTM, so merging. Thank you for the contribution!
Signed-off-by: Hristo Mitrev <[email protected]>
Detailed description
Your checklist for this pull request
Closing issues
#1676