Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Old firmware BMP identification via libusb #1989

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dragonmux
Copy link
Member

Detailed description

In this PR we address an issue uncovered while poking at a BMP running pre-v1.7 firmware where the version string is not embedded in the product string. With probes in this configuration, BMDA will correctly find them but then display "Probe" as the version string and "Black Magic" as the product string due to getting handling of the versionless string wrong.

We address this by porting the Windows BMP-only probe discovery product string parsing to the libusb probe discovery logic, which also allows us to properly address probes that use alternative platforms such as Blue Pills and Black Pills and which may not have a version string if their firmware is too old, thus solving the problem.

Your checklist for this pull request

Closing issues

@dragonmux dragonmux added Bug Confirmed bug BMD App Black Magic Debug App (aka. PC hosted) (not firmware) labels Nov 2, 2024
@dragonmux dragonmux added this to the v2.0 release milestone Nov 2, 2024
@dragonmux dragonmux requested a review from esden November 2, 2024 23:56
@dragonmux dragonmux force-pushed the fix/old-bmp-libusb-ident branch 6 times, most recently from c3437fe to 532fc43 Compare November 9, 2024 04:25
@dragonmux dragonmux force-pushed the fix/old-bmp-libusb-ident branch 4 times, most recently from 4519e54 to ff3c8b5 Compare November 11, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BMD App Black Magic Debug App (aka. PC hosted) (not firmware) Bug Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant