Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set arbitrary service hostname via annotation #17

Closed
wants to merge 1 commit into from

Conversation

pl4nty
Copy link

@pl4nty pl4nty commented Dec 17, 2023

Fixes #14

Tested with ghcr.io/pl4nty/external-mdns

@iamasmith
Copy link
Contributor

iamasmith commented Mar 9, 2024

It strikes me that if this were multi-value with an annotation like /hostnames, possibly comma separated, then this would also offer a workaround for #21 as well.
I'll pull your branch, rework and test and offer it back to you to consider as an update to this PR if that sounds reasonable?
Actually, I just took a quick look, this is a bigger change than I first thought and won't really leave anything of your original code.
I'll raise a separate PR but ack you on it.

@iamasmith
Copy link
Contributor

Alt PR here allowing multiple hostnames and the ability to selectively turn on the more global without-default option for a specific service #22

@blake
Copy link
Owner

blake commented Mar 9, 2024

Hi @pl4nty, thanks for the contribution. I think this is a great addition.

@iamasmith's recent PR includes your work as well as some additional enhancements. Would you be opposed to me closing this PR in favor of #22?

@blake blake self-assigned this Mar 9, 2024
@blake blake added the enhancement New feature or request label Mar 9, 2024
@pl4nty
Copy link
Author

pl4nty commented Mar 10, 2024

Sounds good, I'm happy to build/test the replacement PR too

@pl4nty pl4nty closed this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose service with arbitrary hostname
3 participants