adding dshape parameter to CSV #476
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywang007
changed the title
added 2 commits
August 16, 2016 10:16
ywang007
changed the title
| # explicitly test that we do NOT preserve the header here | ||
| assert discover(csv).measure.names != discover(sql).measure.names | ||
| # explicitly test that we do NOT preserve the header here ??? | ||
| #assert discover(csv).measure.name != discover(sql).measure.name |
There was a problem hiding this comment.
Is there a reason the header should NOT be preserved? Or was it just not preserved before because we kept rediscovering the datashape?
|
@kwmsmith, since we are adding the datashape parameter for a very specific purpose, that is to allow user force one when he's not satisfied with the discovered one, I figure it's better to use a different variable name, user_dshape, to make it more explicit, and avoid conflicts with any internal use of "dshape" parameter by odo. This will require us to update blaze doc accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves part of #461 issue, so that when dshape is provided, it is taken by CSV.
However, this does not resolve the root of data type mismatch in #461.