Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue/comment mocks #1253

Merged

Conversation

OlegMoshkovich
Copy link
Member

This PR:

  • Replaces all personal information in the issue/comment mocks with generic information.
  • Removes the avatar_url property from the user object to default to a generic user icon as the avatar image.

These changes are meant to fix the current issue with the notes E2E tests.

The Percy run needs to be approved to update Percy goldens.
Only notes Percy build
Full Percy build

@OlegMoshkovich OlegMoshkovich added the bug Something isn't working label Aug 7, 2024
@OlegMoshkovich OlegMoshkovich added this to the Notes 100: Misc milestone Aug 7, 2024
@OlegMoshkovich OlegMoshkovich self-assigned this Aug 7, 2024
Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 72437ac
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/66b350aaf1c6090008c86637
😎 Deploy Preview https://deploy-preview-1253--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 17 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for bldrs-share-v2 ready!

Name Link
🔨 Latest commit 72437ac
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-v2/deploys/66b350aa7aa56d0008668314
😎 Deploy Preview https://deploy-preview-1253--bldrs-share-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@OlegMoshkovich OlegMoshkovich merged commit f98bead into bldrs-ai:main Aug 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants